[Tarantool-patches] [PATCH 2/2] sql: clarify "sql_defer_foreign_keys" setting name

[Nikita Pettik]

On 12 Jul 17:31, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> See 3 comments below.
> 
> On 08.07.2020 13:47, Roman Khabibov wrote:
> > Raname "sql_defer_foreign_keys" setting to
> > "sql_defer_foreign_key_changes".
> 
> 1. 'Raname' -> 'Rename'.
> 
> 2. I think the new name is worse. Changes are done immediately.
> You can't defer them. The flag means defer the foreign key checks,
> not changes. To allow temporary inconsistency if a transaction needs
> it, but still check FKs when it will commit.

Agree, this renaming looks pointless and even misleading.
I see it was suggested by Peter, but I don't see enough
arguments to change the name. Please, reject the patch.
 
> > Follow up #4511
> > 
> > @TarantoolBot document
> > Title: sql_defer_foreign_keys in _space_settings
> 
> 3. There is no such space '_space_settings'.
> 
> > Rename "sql_defer_foreign_keys" setting to
> > "sql_defer_foreign_key_changes".