[Tarantool-patches] [PATCH 5/6] Fix luacheck warnings in src/lua/

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Jul 12 18:37:35 MSK 2020


On 10.07.2020 18:55, Sergey Bronnikov wrote:
> On 18:28 Sun 05 Jul , Vladislav Shpilevoy wrote:
>>> diff --git a/src/lua/msgpackffi.lua b/src/lua/msgpackffi.lua
>>> index f01ffaef0..cb7ad5b88 100644
>>> --- a/src/lua/msgpackffi.lua
>>> +++ b/src/lua/msgpackffi.lua
>>> @@ -603,7 +599,7 @@ local function check_offset(offset, len)
>>>      if offset == nil then
>>>          return 1
>>>      end
>>> -    local offset = ffi.cast('ptrdiff_t', offset)
>>> +    offset = ffi.cast('ptrdiff_t', offset)
>>
>> Unnecessary diff.
> 
> Reverted in a branch.
> 
>>>      if offset < 1 or offset > len then
>>>          error(string.format("offset = %d is out of bounds [1..%d]",
>>>              tonumber(offset), len))

Looks like it is not. I still see it on the branch.
https://github.com/tarantool/tarantool/blob/ligurio/gh-4681-fix-luacheck-warnings-src/src/lua/msgpackffi.lua#L602


More information about the Tarantool-patches mailing list