[Tarantool-patches] [PATCH 0/2] Simplify alter.cc
Timur Safin
tsafin at tarantool.org
Wed Jul 8 13:35:12 MSK 2020
I'm very much infavor to use less verbose try-function blocks -
they significantly reduce verbosity of a C++ code which should
be in between C++ and C functions. So indeed - that's good idiom.
Although I suspect `noexcept` in C++17 is not that much zero-cost
abstraction (it should be verified with all supported compilers) but looks
like it's not adding any extra overhead which we would not have at the moment.
But I have some (debatable) notes about lambda usage. See in patches...
Timur
: From: Aleksandr Lyapunov
: Subject: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc
:
: Since we use C++ we need to use in a way that benefits its advantages.
: As I see, there are tons of try-catch blocks in alter.cc. We should use
: more modern techniques and approaches.
:
: Aleksandr Lyapunov (2):
: alter: use good c++ style
: alter: use proper way to marry C and C++
:
: src/box/alter.cc | 418 +++++++++++++++++++++++---------------------------
: -----
: 1 file changed, 177 insertions(+), 241 deletions(-)
:
: --
: 2.7.4
More information about the Tarantool-patches
mailing list