[Tarantool-patches] [PATCH v1] Block linker flag '--no-undefined'

[Alexander Turenko]

LGTM except two comments below.

Please, ask Igor to do the second review.

> Block linker flag '--no-undefined'

I would highlight the fact that it is for testing libs, not the main
library / executable. Like so: '...for testing .so'.

> Found that opensuse adding linker flag '--no-undefined' which produces
> the fails on building tests. Decided to block this flag due to dynamic
> libraries will be loaded from tarantool executable and will use symbols
> from it. So it is completely okay to have unresolved symbols at build
> time.
> 
> Relates to tarantool/tarantool#4562
> ---
> 
> Github: https://github.com/tarantool/luajit/tree/avtikhon/gh-4562-suse-block-linker-flag
> Issue: https://github.com/tarantool/tarantool/issues/4562
> 
>  test/gh-4427-ffi-sandwich/CMakeLists.txt | 1 +
>  test/lj-flush-on-trace/CMakeLists.txt    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/test/gh-4427-ffi-sandwich/CMakeLists.txt b/test/gh-4427-ffi-sandwich/CMakeLists.txt
> index 995c6bb..6028381 100644
> --- a/test/gh-4427-ffi-sandwich/CMakeLists.txt
> +++ b/test/gh-4427-ffi-sandwich/CMakeLists.txt
> @@ -1 +1,2 @@
> +string(REPLACE "-Wl,--no-undefined" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}")

Can you add the same clarification as you do for tarantool's patch?