[Tarantool-patches] [PATCH 2/4] replication: add advanced tests for sync replication

[Sergey Bronnikov]

Hi, Vlad

Thanks for pointing to this.
Test for which you provide output uses error injection
ERRINJ_SYNC_TIMEOUT introduced in a separate patch [1]. The original
idea is to have an ability to manually control sync timeout.  Triggered
error ER_SYNC_QUORUM_TIMEOUT in a test means that patch in [1] is wrong
or incomplete. Perhaps we should add injection to another place (may be
src/box/txn_limbo.c), not in a src/box/replication.cc.
Could you review [1] and provide a feedback?

1. https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018269.html

Sergey

On 01:20 Fri 03 Jul , Vladislav Shpilevoy wrote:
> I didn't review it properly. Just a local fail:
> 
> [001] replication/qsync_advanced.test.lua             memtx           [ fail ]
> [001] 
> [001] Test failed! Result content mismatch:
> [001] --- replication/qsync_advanced.result	Fri Jul  3 01:14:24 2020
> [001] +++ replication/qsync_advanced.reject	Fri Jul  3 01:17:49 2020
> [001] @@ -538,7 +538,7 @@
> [001]  -- Disable synchronous mode.
> [001]  disable_sync_mode()
> [001]   | ---
> [001] - | - error: A rollback for a synchronous transaction is received
> [001] + | - error: Quorum collection for a synchronous transaction is timed out
> [001]   | ...
> [001]  -- Space is in async mode now.
> [001]  box.space.sync:insert{3} -- async operation must wait sync one

-- 
sergeyb@