[Tarantool-patches] [PATCH 1/2] feedback: determine runtime platform info

Alexander Turenko alexander.turenko at tarantool.org
Sun Jul 5 05:14:13 MSK 2020


On Wed, Jul 01, 2020 at 03:16:10AM +0300, Alexander Turenko wrote:
> > +local function fill_in_platform_info(feedback)
> > +    feedback.os        = jit.os
> > +    feedback.arch      = jit.arch
> > +    feedback.is_docker = detect_docker_environment()
> > +end
> 
> Platform information may be grouped into its own category.
> 
> Nit: I would choose more English friendly name for the 'is_docker'
> property. Say, 'dockerized' or at least 'is_under_docker'.

Whether you'll agree with grouping and renaming or not, the patch LGTM.


More information about the Tarantool-patches mailing list