[Tarantool-patches] [PATCH v2 02/19] replication: introduce replication_synchro_* cfg options

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Jul 3 02:36:14 MSK 2020


Thanks for the review!

>> diff --git a/src/box/box.cc b/src/box/box.cc
>> index 871b0d976..0821ea0a3 100644
>> --- a/src/box/box.cc
>> +++ b/src/box/box.cc
>> @@ -476,6 +476,31 @@ box_check_replication_sync_lag(void)
>>       return lag;
>>   }
>>   +static int
>> +box_check_replication_synchro_quorum(void)
>> +{
>> +    int quorum = cfg_geti("replication_synchro_quorum");
>> +    if (quorum <= 0 || quorum > VCLOCK_MAX) {
> 
> It should be `quorum >= VCLOCK_MAX`, because you can't have VCLOCK_MAX (32)
> 
> instances in a cluster, only 31. Id 0 is used by anonymous replicas.

Indeed, done and squashed.


More information about the Tarantool-patches mailing list