[Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json formatter early

Oleg Babin olegrok at tarantool.org
Thu Jul 2 13:29:42 MSK 2020


Thanks! LGTM.

On 02/07/2020 13:18, Cyrill Gorcunov wrote:
> On Thu, Jul 02, 2020 at 01:05:38PM +0300, Oleg Babin wrote:
>> Hi! Thanks for your patch! LGTM! See one minor nitpick below. I hope you
>> could just force-pushed proposed change.
>>
>> On 02/07/2020 12:50, Cyrill Gorcunov wrote:
>>>    -- Set value to log from box.cfg{}.
>>> -local function box_api_cfg_set(key, value)
>>> +local function box_api_cfg_set(cfg, key, value)
>>>        local log_key = box2log_keys[key]
>>> +    local aux_data
>> Seems this variable is unused and could be dropped.
> Yeah, thanks! Already changed and force pushed.


More information about the Tarantool-patches mailing list