[Tarantool-patches] [PATCH] box: rfc for stacked diagnostic area
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Tue Jan 28 03:23:36 MSK 2020
Hi! Thanks for the fixes!
It is not a second review. I just wanted to say that I am
going to spend less time on reviewes to the end of this
week due to intensive preparations to FOSDEM. I will get
back to this RFC as soon as I can, I didn't forget.
Just one comment for now, below.
>>> +* **Issues**: [#1148](https://github.com/tarantool/<repository\>/issues/1148)
>>> +
>>
>> 2. You missed 'Summary' section.
>
> I believe it is redundant for such brief RFC.
>
Nevertheless, please, add it. If that RFC is so simpler,
then it should not be a problem to make it match the
RFC template. Template says:
"Short description what, why and how is implemented."
So just say something like
The document describes a stacked diagnostics feature. The
feature is needed for the cases, when there is a complex and
big callstack with different subsystems in it, and sometimes
the most lowlevel error is not descriptive enough. So it is
wanted to be able to look at errors along the whole callstack
from the place where a first error happened. The feature
implementation is going to change a fiber's error object to a
list of objects, a stack. Its first element will always be
created by the deepest and the most basic errors.
Or anything you think would be better here.
More information about the Tarantool-patches
mailing list