[Tarantool-patches] [PATCH] Increase limits for debug.traceback

[Sergey Voinov]

Hi Igor!

Thanks for your elaborate review!
Please see my answers.


>>  /* Note: changing the following defines breaks the Lua 5.1 ABI. */
>> -#define LUA_INTEGERptrdiff_t
>> -#define LUA_IDSIZE60/* Size of lua_Debug.short_src. */
>> +#define LUA_INTEGER    ptrdiff_t
>> +#define LUA_IDSIZE    128 /* Size of lua_Debug.short_src. */
>> +#define LUA_IDSIZE_ERR  60  /* Size of error message */
>
>I don't get the reason to introduce a separate constant for a single
>line sources. Could you please provide a bit more extended rationale?

The problem here is that if I allow 128 for size of error messages, all error outputs will be longer and there will be need to fix vast amount of test result outputs (.result files). Also, these long outputs will flood tarantool output. I don't think there is a reason to increase error message size. Do you?

Thanks.

-- 
Sergey Voinov