[Tarantool-patches] [PATCH 2/2] box/applier: add missing diag_set on region_alloc failure

Cyrill Gorcunov gorcunov at gmail.com
Mon Jan 20 11:44:09 MSK 2020


On Mon, Jan 20, 2020 at 11:31:48AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [20/01/17 16:32]:
> > In case if we're hitting memory limit allocting triggers
> > we should setup diag error to prevent nil dereference
> > in diag_raise call for example from applier_apply_tx.
> 
> It used to be region_alloc_xc, which would throw exception.
> 
> So it's a regression introduced by some of the "cleanup" patches.
> 
> Could you please find when it was introduced?

Will do. Still there are some other places where diag is not set
so we're narrowing the real case now with help of testing runs
the issue reporter kindly agreed to do.


More information about the Tarantool-patches mailing list