[Tarantool-patches] [PATCH] sql: allow accessing list of collations via pragma

Nikita Pettik korablev at tarantool.org
Fri Jan 17 22:15:28 MSK 2020


On 16 Jan 11:41, Chris Sosnin wrote:
> Hi! Thank you for the review!
> 
> > Content returned by 'pragma collation_list' is already verified in
> > sql-tap/collation.test.lua. So I guess it is enough to check that
> > box.execute("pragma collation_list") does not throw an error.
> 
> I'm sorry, didn't notice such test exists. I changed the patch so it only
> checks for an error:
> +-- gh-4713 "PRAGMA collation_list" is not accessible to all users
> +_, err = box.execute('pragma collation_list')
> +assert(err == nil)
> 
> See the whole patch below.
> 
> 'pragma collation_list' uses _collation space, although user
> may have no access to it. Thus, we replace it with the
> corresponding view.
> 
> Closes #4713
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4713-pragma-collation-list
> issue: https://github.com/tarantool/tarantool/issues/4713

Pushed to master, 2.2 and 2.3 branches. Thanks.
 


More information about the Tarantool-patches mailing list