[Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval()

Konstantin Osipov kostja.osipov at gmail.com
Fri Jan 17 10:47:25 MSK 2020

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [20/01/17 00:57]:
> box_process_call/eval() in the end check if there is an
> active transaction. If there is, it is rolled back, and
> an error is set.
> But rollback is not needed anymore, because anyway in
> the end of the request the fiber is stopped, and its
> not finished transaction is rolled back. Just setting
> of the error is enough.

(and lgtm)

This patch imho is necessary since it "seals" correctness of the
previous patch - if the previous patch is broken, after this
patch is applied, we're going to get assertion failures in
txn_init(). Very nice.

Konstantin Osipov, Moscow, Russia

More information about the Tarantool-patches mailing list