[Tarantool-patches] [PATCH v3] error: add __concat method to error object

Oleg Babin olegrok at tarantool.org
Wed Jan 15 15:35:42 MSK 2020


Thanks!

I've changed commit message and force pushed it to the top of my branch:
https://github.com/tarantool/tarantool/tree/olegrok/4489-concat-for-errors

New commit message:

commit a9ad4bdfa51174223e0d10ef0b6a751fd15a6d8e (HEAD -> 
olegrok/4489-concat-for-errors, origin/olegrok/4489-concat-for-errors)
Author: Oleg Babin <babinoleg at mail.ru>
Date:   Fri Jan 10 18:35:03 2020 +0300

     error: add __concat method to error object

     Usually functions return pair `nil, err` and expected that err is 
string.
     Let's make the behaviour of error object closer to string
     and define __concat metamethod.

     The case of error "error_mt.__concat(): neither of args is an error"
     is not covered by tests because of #4723

     Closes #4489


On 15/01/2020 14:26, Alexander Turenko wrote:
> LGTM.
> 
> Just two minor comments re commit message.
> 

---
Oleg Babin


More information about the Tarantool-patches mailing list