[Tarantool-patches] [PATCH] box: sql prepare and execute statistics should be reflected in box.stat()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Feb 25 23:29:22 MSK 2020


LGTM as well.

On 25/02/2020 14:02, Nikita Pettik wrote:
> On 25 Feb 14:08, Maria Khaydich wrote:
>>
>> Thanks for the review, all done:
>> ----------------------------------------------------------------------
>> Calling prepare and execute did not update corresponding request statistics
>> in the box.stat table. This happened because methods that collect stats were
>> never called where they should have been.
>>  
>> Closes #4756
>> ---
>> Issue:
>> https://github.com/tarantool/tarantool/issues/4756  
>> Branch:
>> https://github.com/tarantool/tarantool/compare/eljashm/gh-4756-box-stat-execute-and-prepare-not-updated  
>>  
>> @ChangeLog
>> - Fixed box.stat behavior - now it collects statistics on
>>     prepare and execute methods as it should.
>>     gh-4756
> 
> LGTM. Vlad, is patch OK with you? If so, I will push it to master, 2.3 and
> partially (only part related to EXECUTE statistics) to 2.2.
> 


More information about the Tarantool-patches mailing list