[Tarantool-patches] [PATCH 07/14] box/txn: rename txn_write to txn_commit_async

Cyrill Gorcunov gorcunov at gmail.com
Sun Feb 23 00:00:14 MSK 2020


On Sat, Feb 22, 2020 at 11:28:41PM +0300, Georgy Kirichenko wrote:
> Hi!
> 
> Well done but I have a minor remark about some renames you suggest.
> So if we would like to talk about synchronous replication then renaming
> txn_write to txn_commit seems quite incorrect as there would be two stages
> of transaction commit - transaction was written to journal and then 
> transaction was completed(with commit or rollback). And the stages should be 
> distinguishable.
> Obviously it depends on further implementation so I let the final resolution up 
> to you.

Thanks! You know at first I need to finish the series and have
everything working and passing tests, so I'll resend the updated
series and then we will discuss the better naming, sounds good?


More information about the Tarantool-patches mailing list