[Tarantool-patches] [PATCH 03/14] box/journal: sanitize completion naming

Nikita Pettik korablev at tarantool.org
Thu Feb 20 17:15:01 MSK 2020


On 20 Feb 17:12, Nikita Pettik wrote:
> On 19 Feb 21:37, Cyrill Gorcunov wrote:
> > Instead of on_done use on_complete prefix
> > since done it too general while we're trying
> > to complete write procedue. Also it is more
> > consistent with txn_complete name.
> > 
> > Acked-by: Konstantin Osipov <kostja.osipov at gmail.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> > ---
> >  src/box/journal.c |  8 ++++----
> >  src/box/journal.h | 12 ++++++------
> >  2 files changed, 10 insertions(+), 10 deletions(-)
> >
> 
> LGTM
> 
> Btw why not to do the same with txn_entry_done_cb ?
>

Nevermind, it is done in the next patch (I've accidentally skipped it).
  


More information about the Tarantool-patches mailing list