[Tarantool-patches] [PATCH 01/14] box/txn: fix void args mess

Nikita Pettik korablev at tarantool.org
Thu Feb 20 17:10:48 MSK 2020


On 19 Feb 21:37, Cyrill Gorcunov wrote:
> Using void explicitly in functions which take
> no arguments allows to optimize code a bit and
> don't assume if there might be variable args.
> 
> Moreover in commit e070cc4d9 we dropped arguments
> from txn_begin but didn't update vy_scheduler.c.
> The compiler didn't complain because it assumed
> there are vargs.
> 
> Acked-by: Konstantin Osipov <kostja.osipov at gmail.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>

LGTM. I assume you can push such patches aimed solely at refactoring
(taking into account second ack).



More information about the Tarantool-patches mailing list