[Tarantool-patches] [PATCH v10 2/4] box/applier: add missing diag_set on region_alloc failure

Konstantin Osipov kostja.osipov at gmail.com
Sat Feb 15 20:34:28 MSK 2020


* Cyrill Gorcunov <gorcunov at gmail.com> [20/02/14 17:06]:
> In case if we're hitting memory limit allocating triggers
> we should setup diag error to prevent nil dereference
> in diag_raise call (for example from applier_apply_tx).
> 
> Note that there are region_alloc_xc helpers which are
> throwing errors but as far as I understand we need the
> rollback action to process first instead of immediate
> throw/catch thus we use diag_set.
> 
> Acked-by: Sergey Ostanevich <sergos at tarantool.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>

lgtm

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list