[Tarantool-patches] [PATCH v8 2/2] fiber: leak slab if unable to bring prots back

[Konstantin Osipov]

* Cyrill Gorcunov <gorcunov at gmail.com> [20/02/14 16:25]:
> In case if we unable to revert guard page back to
> read|write we should never use such slab again.
> 
> Initially I thought of just put panic here and
> exit but it is too destructive. I think better
> print an error and continue. If node admin ignore
> this message then one moment at future there won't
> be slab left for use and creating new fibers get
> prohibited.
> 
> In future (hopefully near one) we plan to drop
> guard pages to prevent VMA fracturing and use
> stack marks instead.

Seriously, let's have some decency, first we pushed an optional
feature and then it broke and you're suggestinga hot fix that leaks 
memory.

What's the issue with disabling the broken feature?


-- 
Konstantin Osipov, Moscow, Russia