[Tarantool-patches] [PATCH 1/1] fio: close unused descriptors automatically
Kirill Yukhin
kyukhin at tarantool.org
Fri Feb 14 14:48:26 MSK 2020
Hello,
On 10 фев 20:36, Vladislav Shpilevoy wrote:
> Hi!
>
> On 10/02/2020 07:31, Kirill Yukhin wrote:
> > Hello,
> >
> > On 09 фев 18:37, Vladislav Shpilevoy wrote:
> >> test/app/fio.result | 93 +++++++++++++++++++++++++++++++++++++++++++
> >> test/app/fio.test.lua | 58 +++++++++++++++++++++++++++
> >
> > Could you please put the test into separate file?
>
> It contradicts with SOP.
>
> "
> We do not create a separate file for each feature - that
> would lead to a huge number of files. For a bug fix,
> please create a separate file with autonomous test case in
> a correponding test suite. Name should follow this format:
> <suite name>/gh-XXX-two-three-word-title
> "
>
> This is not a bugfix. It is a feature. Auto GC of FIO was never
> documented anywhere, so this was not a bug. And according to SOP
> it should not be in a separate file. But ok, I moved it.
Thanks for doing this and for mentioning that this is actually a
feature. I've chanched corresponding label of the issue and
moved it to latest MS since we do not commit features to release
branches.
--
Regards, Kirill Yukhin
More information about the Tarantool-patches
mailing list