[Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at madvise/mprotect failure

Cyrill Gorcunov gorcunov at gmail.com
Fri Feb 14 10:56:50 MSK 2020


On Fri, Feb 14, 2020 at 12:26:09AM +0100, Vladislav Shpilevoy wrote:
> >> 4. Do you need C++ here?
> > 
> > The C++ was choosen because we already have fiber_XXX.cc tests
> > so I simply tried to follow.
> > 
> >> 5. I would call it fiber_errinj.c. In future we may want to
> >> add more tests here, which use error injections. Up to you.
> > 
> > From one point of view having one big test which would cover
> > various aspects of tarantool might help discovering unexpectedly
> > connected bugs.
> 
> In case of unit tests it is rather about reducing code duplication.
> Because any fiber unit test on C includes the same headers, does
> the same preparations in main(), may need some common utilities.

I see what you mean but still prefer to have stack testings in
separate test.


More information about the Tarantool-patches mailing list