[Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn

Sergey Petrenko sergepetrenko at tarantool.org
Fri Feb 14 01:05:49 MSK 2020




>Четверг, 13 февраля 2020, 9:48 +03:00 от Konstantin Osipov <kostja.osipov at gmail.com>:
>
>* sergepetrenko < sergepetrenko at tarantool.org > [20/02/13 09:34]:
>> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't
>> fire in release builds, of course. So we better panic on an attemt to
>> write a record with a duplicate or otherwise broken lsn.
>> 
>
>It should be a warning in production. You can't crash production
>deploy because of a server bug, and lsn inconsistency is always a
>server bug.
Well, this inconsistency yields a WAL that cannot be recovered from.
But I don't have a strong opinion here. I changed it to a warning in v2.
>
>
>-- 
>Konstantin Osipov, Moscow, Russia


-- 
Sergey Petrenko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20200214/45df164e/attachment.html>


More information about the Tarantool-patches mailing list