[Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn
sergepetrenko
sergepetrenko at tarantool.org
Thu Feb 13 02:51:01 MSK 2020
There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't
fire in release builds, of course. So we better panic on an attemt to
write a record with a duplicate or otherwise broken lsn.
Follow-up #4739
---
src/box/wal.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/box/wal.c b/src/box/wal.c
index 0ae66ff32..3d4317f34 100644
--- a/src/box/wal.c
+++ b/src/box/wal.c
@@ -951,9 +951,18 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base,
(*row)->tsn = tsn;
(*row)->is_commit = row == end - 1;
} else {
- vclock_follow(vclock_diff, (*row)->replica_id,
- (*row)->lsn - vclock_get(base,
- (*row)->replica_id));
+ int64_t diff = (*row)->lsn - vclock_get(base, (*row)->replica_id);
+ if (diff <= vclock_get(vclock_diff,
+ (*row)->replica_id)) {
+ panic("Attempt to write a broken LSN to WAL:"
+ " replica id: %d, committed lsn: %d,"
+ " new lsn %d", (*row)->replica_id,
+ vclock_get(base, (*row)->replica_id) +
+ vclock_get(vclock_diff,
+ (*row)->replica_id),
+ (*row)->lsn);
+ }
+ vclock_follow(vclock_diff, (*row)->replica_id, diff);
}
}
}
--
2.20.1 (Apple Git-117)
More information about the Tarantool-patches
mailing list