[Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator
Nikita Pettik
korablev at tarantool.org
Wed Feb 12 17:10:42 MSK 2020
On 12 Feb 00:27, Vladislav Shpilevoy wrote:
> On 12/02/2020 00:20, Nikita Pettik wrote:
> > On 11 Feb 23:17, Vladislav Shpilevoy wrote:
> >> Hi!
> >>
> >> I've pushed my review fixes on top of this commit. See it in the
> >> end of the email, and on the branch.
> >>
> >> 3.2 and 3.13 still were the same, I dropped 3.13.
> >
> > Don't bother with such insignificant things, I am always ok with these fixes.
> > Just amend them and force push already squashed :)
>
> Ok, will take that into account next time
>
> > Ofc I've applied your fixes, thanks.
>
> The patchset LGTM then.
Pushed to master only. Milestone for this issue is 2.2.3, but 2.2 lacks
DOUBLE type, so patches can't be applied.
I did not push to 2.3 since I don't consider this issue to be a bug,
but rather behaviour change in type system. However, if somebody
insists on adding this change to 2.3 then I won't mind.
More information about the Tarantool-patches
mailing list