[Tarantool-patches] [PATCH v4 0/3] box: session settings fixes

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Feb 4 01:17:20 MSK 2020


Hi! Thanks for the patchset!

I see that you have 1 more commit on top of the ones listed
below. Please, next time send 2 separate branches.

On 28/01/2020 13:50, Chris Sosnin wrote:
> Changes in v3:
> - add a patch that removes setting modules
> - apply Vlad's fixes
> 
> Changes in v4:
>  - add lua frontend for accessing session settings
>  - move settings initialization into session.c
> 
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712-search-settings
> issue #1: https://github.com/tarantool/tarantool/issues/4711
> issue #2: https://github.com/tarantool/tarantool/issues/4712
> 
> Chris Sosnin (3):
>   box: replace session_settings modules with a single array
>   box: add binary search for _session_settings space
>   box: provide a user friendly frontend for accessing session settings
> 
>  src/box/lua/session.c                         | 106 +++++++++++
>  src/box/session_settings.c                    | 180 +++++++++++-------
>  src/box/session_settings.h                    |  47 +++--
>  src/box/sql.c                                 |   5 -
>  src/box/sql/build.c                           |  60 ++----
>  ...1-access-settings-from-any-frontend.result |  94 +++++++--
>  ...access-settings-from-any-frontend.test.lua |  45 ++++-
>  7 files changed, 378 insertions(+), 159 deletions(-)
> 


More information about the Tarantool-patches mailing list