[Tarantool-patches] [PATCH v2 1/2] fiber: use diag_ logger in fiber_madvise/mprotect failures

[Cyrill Gorcunov]

On Tue, Feb 04, 2020 at 12:56:27AM +0300, Alexander Turenko wrote:
> Everything looks correct.
> 
> However, I don't believe my eyes, so I wrote a test case (see below).
> 
> Don't sure whether it is good to have error injections for such
> functions. Maybe LD_PRELOAD way is better (see [1]). Anyway, I checked
> that the behaviour was incorrect using the test and that it becomes
> correct.
> 
> Please, consider the shared test and decide whether it worth to add it
> to the repository (I don't sure).

I think having errinj is better in a long term, it is controllable
by our code and doesn't depend on any other hooks. Except

 - I would call it just FIBER_MPROTECT (without prot-none suffix)
 - iirc there was some test in app/ errinj or similar which should
   be updated everytime new errinj introduced.

With this two things addressed feel free to put my Ack. And thanks
a huge, Sasha, for this test