[Tarantool-patches] [PATCH v7 1/5] box/request: add missing OutOfMemory diag_set
Sergey Ostanevich
sergos at tarantool.org
Mon Feb 3 17:37:08 MSK 2020
Thanks!
LGTM.
Sergos
On 28 Jan 22:22, Cyrill Gorcunov wrote:
> In request_create_from_tuple and request_handle_sequence
> we may be unable to request memory for tuples, don't
> forget to setup diag error otherwise diag_raise will
> lead to nil dereference.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
> src/box/request.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/box/request.c b/src/box/request.c
> index 82232a155..994f2da62 100644
> --- a/src/box/request.c
> +++ b/src/box/request.c
> @@ -109,8 +109,10 @@ request_create_from_tuple(struct request *request, struct space *space,
> * the tuple data to WAL on commit.
> */
> char *buf = region_alloc(&fiber()->gc, size);
> - if (buf == NULL)
> + if (buf == NULL) {
> + diag_set(OutOfMemory, size, "region_alloc", "tuple");
> return -1;
> + }
> memcpy(buf, data, size);
> request->tuple = buf;
> request->tuple_end = buf + size;
> @@ -199,8 +201,10 @@ request_handle_sequence(struct request *request, struct space *space)
> size_t buf_size = (request->tuple_end - request->tuple) +
> mp_sizeof_uint(UINT64_MAX);
> char *tuple = region_alloc(&fiber()->gc, buf_size);
> - if (tuple == NULL)
> + if (tuple == NULL) {
> + diag_set(OutOfMemory, buf_size, "region_alloc", "tuple");
> return -1;
> + }
> char *tuple_end = mp_encode_array(tuple, len);
>
> if (unlikely(key != data)) {
> --
> 2.20.1
>
More information about the Tarantool-patches
mailing list