[Tarantool-patches] [PATCH v2 1/1] sql: make NUMBER to be union of SQL numeric types

[Mergen Imeev]

On Tue, Jan 28, 2020 at 07:23:29PM +0300, Nikita Pettik wrote:
> On 23 Jan 16:40, Mergen Imeev wrote:
> > Hi! Thank you for review. My answers and new commit-message
> > below.
> 
> Hi,
> 
> I've a bit reworked your patch: splitted it into consistent sequence of
> independent patches and provided refactoring for sqlVdbeMemNumerify().
> Also I found that CAST boolean AS NUMBER didn't work properly: cast resulted
> in error meanshile cast boolean as integer is legal, so that as number should
> be legal as well. There's no more functional changes except for mentioned one.
> Please look at branch: https://github.com/tarantool/tarantool/commits/np/gh-4233-fix-number-field-type-in-sql
> 
> If it is OK to you please reply and I will push patches to master bracnch.
> Thanks. 
>  
Hi,

I'm sorry, but I do not like it. Since now it is yours
commits, I'll ask Sasha to move issues #4233 and #4463
to you. If you want a review, please ask Vlad.