[Tarantool-patches] [PATCH luajit 1/3] misc: fix build with disabled memory profiler
Sergey Kaplun
skaplun at tarantool.org
Wed Dec 30 11:52:18 MSK 2020
Hi, Igor!
Thanks for the review!
On 30.12.20, Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! LGTM with a single nit below.
>
> On 30.12.20, Sergey Kaplun wrote:
> > This patch fixes the regression introduced in scope of
> > b4e6bf0d82100049d29af1aa3196e781270f39d1 ('misc: add Lua API for memory
> > profiler'). Build is failed with disabled memory profiler because
>
> Typo: s/is failed/fails/.
Fixed. Branch is force-pushed.
>
> > related error messages are not defined.
> >
> > This patch fixes build by making LJ_ERR_PROF_MISUSE visible and avoiding
> > usage of other profiler-related errors when the profiler is disabled.
> >
> > Follows up tarantool/tarantool#5442
> > ---
> > src/lib_misc.c | 4 ++++
> > src/lj_errmsg.h | 2 +-
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
>
> <snipped>
>
> > --
> > 2.28.0
> >
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list