[Tarantool-patches] [PATCH] box: fix arguments passed to error message

Serge Petrenko sergepetrenko at tarantool.org
Mon Dec 28 12:30:21 MSK 2020


box_wait_quorum() had an extraneous argument to error format string.
Remove it.
Found by Coverity.

CID 1500387
Follow-up #5435
---
sp/coverity-warn
Please, push to 2.6 and master.


 src/box/box.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/box/box.cc b/src/box/box.cc
index e1d8305c8..f2f5bedb4 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -1229,7 +1229,7 @@ box_wait_quorum(uint32_t lead_id, int64_t target_lsn, int quorum,
 	if (ack_count < quorum) {
 		diag_set(ClientError, ER_QUORUM_WAIT, quorum, tt_sprintf(
 			 "timeout after %.2lf seconds, collected %d acks",
-			 timeout, ack_count, quorum));
+			 timeout, ack_count));
 		return -1;
 	}
 	return 0;
-- 
2.24.3 (Apple Git-128)



More information about the Tarantool-patches mailing list