[Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler

[Alexander V. Tikhonov]

Hi Sergey, thanks for the patchset, as I see no new degradation found
in gitlab-ci testing commit criteria pipeline [1], patchset LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/234321640

p.s. failed 'ubuntu_19_10' job already removed from testing.

On Fri, Dec 25, 2020 at 06:26:02PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> 
> This patch provides a Lua interface for memory profiler in LuaJIT
> and the corresponding parser of profiled data.
> 
> Global changes in v2:
>   - Moved symtab to memprof module.
>   - Added LUA_CORE and `module_name`_c defines
>   - Added LJ_FASTCALL in wbuf and leb128 modules.
>   - Added translation units to amalg build.
>   - Code style fixes and commit message fixes.
>   - Added (gh-5490) to ChangeLog.
> 
> Issues: https://github.com/tarantool/tarantool/issues/5442
>         https://github.com/tarantool/tarantool/issues/5490
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5442-luajit-memory-profiler
> 
> CI:     https://gitlab.com/tarantool/tarantool/-/pipelines/234430645
> 
> RFC: https://lists.tarantool.org/pipermail/tarantool-discussions/2020-December/000147.html
> 
> @ChangeLog:
>  - Introduce LuaJIT memory profiler (gh-5442).
>  - Introduce LuaJIT memory profiler parser (gh-5490).
> 
> Sergey Kaplun (7):
>   utils: introduce leb128 reader and writer
>   core: introduce write buffer module
>   vm: introduce VM states for Lua and fast functions
>   core: introduce new mem_L field
>   core: introduce memory profiler
>   misc: add Lua API for memory profiler
>   tools: introduce a memory profile parser
> 
>  Makefile                           |  39 ++-
>  src/Makefile                       |  13 +-
>  src/Makefile.dep                   |  44 +--
>  src/lib_misc.c                     | 167 +++++++++++
>  src/lj_arch.h                      |  22 ++
>  src/lj_debug.c                     |   8 +-
>  src/lj_debug.h                     |   3 +
>  src/lj_errmsg.h                    |   6 +
>  src/lj_frame.h                     |  18 +-
>  src/lj_gc.c                        |   2 +
>  src/lj_memprof.c                   | 430 +++++++++++++++++++++++++++++
>  src/lj_memprof.h                   | 165 +++++++++++
>  src/lj_obj.h                       |  13 +-
>  src/lj_profile.c                   |   5 +-
>  src/lj_state.c                     |   8 +
>  src/lj_utils.h                     |  58 ++++
>  src/lj_utils_leb128.c              | 132 +++++++++
>  src/lj_wbuf.c                      | 141 ++++++++++
>  src/lj_wbuf.h                      |  87 ++++++
>  src/ljamalg.c                      |   3 +
>  src/luajit-gdb.py                  |  14 +-
>  src/vm_arm.dasc                    |   6 +-
>  src/vm_arm64.dasc                  |   6 +-
>  src/vm_mips.dasc                   |   6 +-
>  src/vm_mips64.dasc                 |   6 +-
>  src/vm_ppc.dasc                    |   6 +-
>  src/vm_x64.dasc                    |  93 +++++--
>  src/vm_x86.dasc                    | 131 ++++++---
>  test/misclib-memprof-lapi.test.lua | 135 +++++++++
>  tools/luajit-parse-memprof         |   9 +
>  tools/memprof.lua                  | 109 ++++++++
>  tools/memprof/humanize.lua         |  45 +++
>  tools/memprof/parse.lua            | 188 +++++++++++++
>  tools/utils/bufread.lua            | 147 ++++++++++
>  tools/utils/symtab.lua             |  89 ++++++
>  35 files changed, 2217 insertions(+), 137 deletions(-)
>  create mode 100644 src/lj_memprof.c
>  create mode 100644 src/lj_memprof.h
>  create mode 100644 src/lj_utils.h
>  create mode 100644 src/lj_utils_leb128.c
>  create mode 100644 src/lj_wbuf.c
>  create mode 100644 src/lj_wbuf.h
>  create mode 100755 test/misclib-memprof-lapi.test.lua
>  create mode 100755 tools/luajit-parse-memprof
>  create mode 100644 tools/memprof.lua
>  create mode 100644 tools/memprof/humanize.lua
>  create mode 100644 tools/memprof/parse.lua
>  create mode 100644 tools/utils/bufread.lua
>  create mode 100644 tools/utils/symtab.lua
> 
> -- 
> 2.28.0
>