[Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce leb128 reader and writer

Sergey Ostanevich sergos at tarantool.org
Sat Dec 26 21:47:29 MSK 2020


Hi!

LGTM.

Sergos

> On 26 Dec 2020, at 16:57, Sergey Kaplun via Tarantool-patches <tarantool-patches at dev.tarantool.org> wrote:
> 
> Sorry for my Runglish again.
> Change back articles "an uint" -> "a uint".
> 
> See the iterative patch below. Branch is force-pushed.
> ===================================================================
> diff --git a/src/lj_utils.h b/src/lj_utils.h
> index 63d6c84..f5c1579 100644
> --- a/src/lj_utils.h
> +++ b/src/lj_utils.h
> @@ -29,13 +29,13 @@ size_t LJ_FASTCALL lj_utils_read_leb128_n(int64_t *out, const uint8_t *buffer,
> 					  size_t n);
> 
> /*
> -** Reads a value from a buffer of bytes to an uint64_t output.
> +** Reads a value from a buffer of bytes to a uint64_t output.
> ** No bounds checks for the buffer. Returns number of bytes read.
> */
> size_t LJ_FASTCALL lj_utils_read_uleb128(uint64_t *out, const uint8_t *buffer);
> 
> /*
> -** Reads a value from a buffer of bytes to an uint64_t output. Consumes no more
> +** Reads a value from a buffer of bytes to a uint64_t output. Consumes no more
> ** than n bytes. No bounds checks for the buffer. Returns number of bytes
> ** read. If more than n bytes is about to be consumed, returns 0 without
> ** touching out.
> ===================================================================
> 
> -- 
> Best regards,
> Sergey Kaplun



More information about the Tarantool-patches mailing list