[Tarantool-patches] FW: [PATCH v2 3/3] small: changed small allocator pool management

[Evgeny Mekhanik]

On 23.12.2020 14:14, mechanik20051988 wrote:
> 1. Fxed
> 2. As i understand you comment, you wrote that pools
>    should be aligned on the 8-byte boundary.
>    This is guaranteed by the granularity parameter in small_class if min_alloc
>    have 8-byte boundary alignment. We calculate
>    min_alloc = objsize_min = small_align(objsize_min, sizeof(intptr_t));
>    and pass granularity sizeof(uintptr_t).
 
No, I meant the indentation alignment is broken. If a
function call consists of multiple lines, the non-first
lines should be aligned by '(' + 1. See examples in
the existing code.
 
 Change alignment in code, see below:
+    small_class_create(&alloc->small_class, sizeof(intptr_t),
+                                   alloc->factor, objsize_min);
+    factor_pool_create(alloc);
 
     lifo_init(&alloc->delayed);
     lifo_init(&alloc->delayed_large);
 
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20201225/3c270cdb/attachment.html>