[Tarantool-patches] [PATCH v3 1/5] test: convert print to function and make quotes use consistent

Sergey Bronnikov sergeyb at tarantool.org
Thu Dec 24 13:50:41 MSK 2020


Thanks for review!

On 23.12.2020 18:39, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
>> diff --git a/test/replication-py/swap.test.py b/test/replication-py/swap.test.py
>> index 98eeeea6d..b162ae241 100644
>> --- a/test/replication-py/swap.test.py
>> +++ b/test/replication-py/swap.test.py
>> @@ -7,26 +9,26 @@ import yaml
>>   REPEAT = 20
>>   ID_BEGIN = 0
>>   ID_STEP = 5
>> -LOGIN = 'test'
>> -PASSWORD = 'pass123456'
>> +LOGIN = "test"
>> +PASSWORD = "pass123456"
>>   
>> -engines = ['memtx', 'vinyl']
>> +engines = ["memtx", "vinyl"]
>>   
>>   def insert_tuples(_server, begin, end, msg = "tuple"):
>>       for engine in engines:
>>           for i in range(begin, end):
>> -            print 'box.space.%s:insert{%d, "%s %d"}' % (engine, i, msg, i)
>> -            print '-'
>> +            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, i, msg, i))
> Oh, noooo! There is still ' instead of " !!!

Fixed and force-pushed.

--- a/test/replication-py/swap.test.py
+++ b/test/replication-py/swap.test.py
@@ -17,7 +17,7 @@ engines = ["memtx", "vinyl"]
  def insert_tuples(_server, begin, end, msg = "tuple"):
      for engine in engines:
          for i in range(begin, end):
-            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, 
i, msg, i))
+            print("box.space.{}:insert{{{}, \"{} {}\"}}".format(engine, 
i, msg, i))
              print("-")
              space = _server.iproto.py_con.space(engine)
              print(space.insert((i, "{} {}".format(msg, i))))



More information about the Tarantool-patches mailing list