[Tarantool-patches] [PATCH luajit v1 04/11] profile: introduce symtab write module

[Igor Munkin]

Sergey,

On 24.12.20, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review!
> 
> On 21.12.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! Please consider minor comments below.
> > 
> > On 16.12.20, Sergey Kaplun wrote:

<snipped>

> > > diff --git a/src/profile/ljp_symtab.c b/src/profile/ljp_symtab.c
> > > new file mode 100644
> > > index 0000000..5a17c97
> > > --- /dev/null
> > > +++ b/src/profile/ljp_symtab.c
> > > @@ -0,0 +1,55 @@
> > 
> > <snipped>
> > 
> > > +#define LJS_CURRENT_VERSION 2
> > 
> > Why is it already the second version?
> 
> It's inherited from LuaVela. I didn't know is it right to drop version
> to zero. But AFAICS from your comment it is :)

Why zero? I believe the most natural way to number versions starts with
the *first* version (zero versions are often considered as something not
ready to be released or unstable). Anyway, this value breaks nothing and
should be just incremented for the future symtab changes, so feel free
to use zero, if you want.

> 
> > 
> > > +

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM