[Tarantool-patches] [PATCH luajit v1 02/11] utils: introduce leb128 reader and writer

[Igor Munkin]

Sergey,

On 24.12.20, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review!
> 
> On 21.12.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! Please, consider the comments below.
> > 
> > On 16.12.20, Sergey Kaplun wrote:

<snipped>

> > > diff --git a/src/utils/leb128.c b/src/utils/leb128.c
> > > new file mode 100644
> > > index 0000000..921e5bc
> > > --- /dev/null
> > > +++ b/src/utils/leb128.c
> > > @@ -0,0 +1,124 @@
> > > +/*
> > > +** Working with LEB128/ULEB128 encoding.
> > > +**
> > > +** Major portions taken verbatim or adapted from the LuaVela.
> > > +** Copyright (C) 2015-2019 IPONWEB Ltd.
> > > +*/
> > > +
> > > +#include <stdint.h>
> > > +#include <stddef.h>
> > 
> > Why do you include this again instead of using leb128.h?
> 
> It's enough. Definitions from <leb128.h> is redundant here.

Sorry, what definitions are *redundant* here?

> 
> > 
> > > +

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM