[Tarantool-patches] [PATCH v3 2/2] sql: add panic() call in sql_execute() on complete failure

Leonid Vasiliev lvasiliev at tarantool.org
Thu Dec 24 01:38:49 MSK 2020


Hi! Thank you for the review.

On 20.12.2020 19:02, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> On 17.12.2020 00:09, Leonid Vasiliev via Tarantool-patches wrote:
>> In SQL, on failure sometimes an error sets to the diag, sometimes not.
>> And this can dived to situation as in #5537(SEGFAULT).
> 
> dived -> lead.
> 
>> So, let's call `panic()` in that case, because something is very wrong,
>> and it is not safe to continue execution.
>>
>> Follow-up #5537

Updated:

In SQL, on failure sometimes an error sets to the diag, sometimes not.
And this can lead to situation as in #5537(SEGFAULT).
So, let's call `panic()` in that case, because something is very wrong,
and it is not safe to continue execution.

Follow-up #5537


More information about the Tarantool-patches mailing list