[Tarantool-patches] [PATCH luajit v1 01/11] build: add src dir in building

Sergey Kaplun skaplun at tarantool.org
Wed Dec 23 21:20:37 MSK 2020


Igor,

Thanks for the review!

On 21.12.20, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch, but I guess we need to restructure the sources in
> a separate series if we want to (but I personally strongly doubt).
> 
> I don't want to mix the new layout you want to introduce with the
> feature. E.g. we already introduced <lib_misc.c>, however, I also prefer
> the uJIT layout (i.e. lib/misc.c). LuaJIT already provides a profiler
> that is implemented in scope of lj_profile.[hc]. Let's leave everything
> "flat" in <src> directory to save the sources consistency. Please, drop
> this patch out of the series.

OK, I'll drop this commit.

Side note: At least we should change the layout of all sources (if we
want) after we'll sync up with upstream. It makes this procedure less
painful. As for me new layout _after_ sync up will not disturb
applying single patches.

> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun


More information about the Tarantool-patches mailing list