[Tarantool-patches] [PATCH luajit v1 00/11] LuaJIT memory profiler

Igor Munkin imun at tarantool.org
Mon Dec 21 13:43:42 MSK 2020


Sergey,

Thanks for the series! I reviewed the patches (1..4, 7, 10) and expect
considerable changes in both code and sources layout, so I guess we can
proceed in the v2. Anyway, the patches 5 and 6 looks independent to
these changes and I review them in a while. The patches 8, 9 and 11 may
change in the next version, so I'll glance them but the full review will
be made for the next version.

On 16.12.20, Sergey Kaplun wrote:
> This patch provides a Lua interface for memory profiler in LuaJIT
> and the corresponding parser of profiled data.
> 
> Issues: https://github.com/tarantool/tarantool/issues/5442
>         https://github.com/tarantool/tarantool/issues/5490
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5442-luajit-memory-profiler
> 
> CI:     https://gitlab.com/tarantool/tarantool/-/pipelines/230917973
> 
> RFC: https://lists.tarantool.org/pipermail/tarantool-discussions/2020-December/000144.html
> 
> @ChangeLog:
>  - Introduce LuaJIT memory profiler (gh-5442).

IIRC, there is a separate issue for memprof parse, so it's worth to add
it to the ChangeLog also.

> 
> Sergey Kaplun (11):
>   build: add src dir in building
>   utils: introduce leb128 reader and writer
>   profile: introduce profiler writing module
>   profile: introduce symtab write module
>   vm: introduce LFUNC and FFUNC vmstates
>   core: introduce new mem_L field
>   debug: move debug_frameline to public module API
>   profile: introduce memory profiler
>   misc: add Lua API for memory profiler
>   tools: introduce tools directory
>   profile: introduce profile parser
> 

<snipped>

> 
> -- 
> 2.28.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list