[Tarantool-patches] [PATCH v2] base64: Properly ignore invalid characters
Alexander Turenko
alexander.turenko at tarantool.org
Thu Dec 17 15:41:59 MSK 2020
On Thu, Dec 17, 2020 at 12:41:48PM +0300, Leonid Vasiliev via Tarantool-patches wrote:
> Hi! Thank you for the patch.
> Generally LGTM.
> See some comments below:
>
> According to https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
> "Description is what the patch does, started from lowercase letter,
> without a dot in the end, in the imperative mood."
> ("properly...").
> I could be wrong, but it seems like <description> is not written in an
> imperative mood.
A commit subject should be in the imperative mood. But there is more
freedom for a commit message body.
More information about the Tarantool-patches
mailing list