[Tarantool-patches] [PATCH v3] luacheck: change global vars to local in sql-tap

[Kirill Yukhin]

Hello,

On 14 Dec 21:10, Artem Starshov via Tarantool-patches wrote:
> Fixed luacheck warning 111 (setting non-standard global variable)
> in test/sql-tap directory.
> Enabled this directory for checking W111 in
> config file(.luacheckrc).
> 
> Changed almost all variables in test/sql-tap from globals
> to locals. In any cases, where variables need to be global,
> added explicit _G. prefix (table of globals).
> 
> Fixes #5173
> Part-of #5464
> ---
> Changes in v3:
>     - inline "globals" suppressions changed to _G usage
>     - removed some unnecessary suppressions
>     - rebased to master and corrected newly appeared tests
> 
> See LGTM from AlexTu: https://lists.tarantool.org/pipermail/tarantool-patches/2020-December/021194.html
> Branch:https://github.com/tarantool/tarantool/tree/artemreyt/gh-5173-fix-luacheck-warnings-sql-tap
> Issue: https://github.com/tarantool/tarantool/issues/5173

LGTM.
I've checked your patch into 2.5, 2.6 and master.

--
Regards, Kirill Yukhin