[Tarantool-patches] [PATCH v2 1/3] sql: add missing diag_set on failure when working with files inside SQL module

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Dec 16 01:12:53 MSK 2020


Thanks for the fixes!

What about missing diag in robust_ftruncate()?

In findInodeInfo() you can get -1 from fstat().

unixFileLock() can return -1 from fcntl().

seekAndRead() and seekAndWriteFd() can return -1
from lseek() and read().

fcntlSizeHint() and unixMapfile() can return -1
from fstat().

unixGetTempname() can return -1, but I don't see if
it even sets errno.

getFileMode() can return -1 from stat().

unixDelete() can return -1 from unlink(), fstat()

I suggest to fix everything. It is all in one file and all
is related.


More information about the Tarantool-patches mailing list