[Tarantool-patches] [PATCH 4/4] test: remove dead code in Python tests end extra newline

Sergey Bronnikov sergeyb at tarantool.org
Tue Dec 15 16:00:52 MSK 2020


On 15.12.2020 15:51, Leonid Vasiliev wrote:
> Hi! Thank you for the patch.
> Generally LGTM.
> Look one commit below:
>
> On 11.12.2020 11:42, Sergey Bronnikov via Tarantool-patches wrote:
>> From: Sergey Bronnikov <sergeyb at tarantool.org>
>> <snipped>
>> index b1442c520..a40133ef2 100644
>> --- a/test/xlog-py/dup_key.test.py
>> +++ b/test/xlog-py/dup_key.test.py
>> @@ -3,11 +3,6 @@ from __future__ import print_function
>>   import os
>>   import yaml
>>   -#print """
>> -#A test case for https://bugs.launchpad.net/tarantool/+bug/1052018
>> -#panic_on_wal_error doesn't work for duplicate key errors
>> -#"""
>
> Seems like
> ```
> #A test case for https://bugs.launchpad.net/tarantool/+bug/1052018
> #panic_on_wal_error doesn't work for duplicate key errors
> ```
> can be left as a comment to the test (without `print`).

Agree.

--- a/test/xlog-py/dup_key.test.py
+++ b/test/xlog-py/dup_key.test.py
@@ -3,6 +3,9 @@ from __future__ import print_function
  import os
  import yaml

+# A test case for https://bugs.launchpad.net/tarantool/+bug/1052018
+# panic_on_wal_error doesn't work for duplicate key errors
+
  server.stop()
  server.deploy()

>
>> -
>>   server.stop()
>>   server.deploy()
>>   diff --git a/test/xlog-py/lsn_gap.test.py 
>> b/test/xlog-py/lsn_gap.test.py
>> index 8da6166a2..b80b97146 100644
>> --- a/test/xlog-py/lsn_gap.test.py
>> +++ b/test/xlog-py/lsn_gap.test.py
>> @@ -38,4 +38,3 @@ print("")
>>     # missing tuple from removed xlog
>>   server.admin("box.space.test:select{}")
>> -
>>


More information about the Tarantool-patches mailing list