[Tarantool-patches] [PATCH v6 0/3] iproto: greeting enhancement
Ilya Kosarev
i.kosarev at tarantool.org
Sun Dec 13 02:38:44 MSK 2020
These patches move greeting from tx thread to iproto and introduce
minor improvements into iproto logic.
Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3776-handling-connections-in-iproto
Issue: https://github.com/tarantool/tarantool/issues/3776
Changes in v2:
- docbot request provided
- ChangeLog provided
- net_send_msg() used instead of net_send_error() where needed
- error cases made clear in iproto_msg_decode()
- replaced net_check_connection() with iproto_connection_fail() predicate
- improved tx session initialization fail processing to avoid extra tries
- fixed obuf_dup() fail processing in iproto_process_connect()
- added some comments
- some comments style fixed
Changes in v3:
- added braces to the confusing one-line if statement
- updated ChangeLog
- added description for iproto_msg_decode()
- simplified error processing in iproto_msg_decode()
Changes in v4:
- fixed msg->close_connection initialization bug
- fixed false-sharing problem in iproto_connection struct
- added needed assertion
- added needed comments
- names refactoring
- simplified patch a bit: removed extra return value, extra
Changes in v5:
- reworked to avoid lazy initialization and extra changes
Changes in v6:
- some changes are picket out into separate commits
- main commit message rewrited to become more comprehensive
- removed some extra changes
- style fixes
- greeting allocation fixed
Ilya Kosarev (3):
iproto: move msg fields initialization to iproto_msg_new()
iproto: fix comment and add assert on destruction
iproto: move greeting from tx thread to iproto
src/box/iproto.cc | 125 +++++++++++++-----
test/app/gh-4787-netbox-empty-errmsg.result | 18 ---
test/app/gh-4787-netbox-empty-errmsg.test.lua | 8 --
3 files changed, 92 insertions(+), 59 deletions(-)
--
2.17.1
More information about the Tarantool-patches
mailing list