[Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal handling in

[Cyrill Gorcunov]

On Fri, Dec 11, 2020 at 12:31:18PM +0300, Serge Petrenko wrote:
> > --- /dev/null
> > +++ b/src/lib/core/crash.c
> > @@ -0,0 +1,291 @@
> > +/*
> > + * SPDX-License-Identifier: BSD-2-Clause
> > + *
> > + * Copyright 2010-2020, Tarantool AUTHORS, please see AUTHORS file.
> 
> 
> I haven't seen us using such a license before.
> It must be fine, I'm just not familiar with this.

We've been discussing this spdx reference in chat and I've got no
rejection so far. So I think using short ref a way more convenient
instead of pushing the big header to each file.

https://spdx.org/licenses/
https://en.wikipedia.org/wiki/Software_Package_Data_Exchange

> > +static void
> > +crash_report_stderr(struct crash_info *cinfo)
> > +{
> > +	if (cinfo->signo == SIGSEGV) {
> > +		fprintf(stderr, "Segmentation fault\n");
> > +		const char *signal_code_repr = 0;
> 
> 
> Please use NULL for pointers.

Both comments are fixed and force pushed. Thanks!