[Tarantool-patches] [PATCH 1/6] test: support Python 3 and make quotes use consistent

Sergey Bronnikov sergeyb at tarantool.org
Thu Dec 10 16:29:14 MSK 2020


On 10.12.2020 16:23, Sergey Bronnikov via Tarantool-patches wrote:
> Hello,
>
> thanks for review
>
>
>> Hi! Thank you for the patch!
>> I regret the moment when I suggested at the same time reformat the code
>> in accordance with the PEP8) (Many changes).
>> But for tests, in my opinion it is normal. This is easy to check and
>> can't introduce degradation.
>> In addition, I think LGTM alone will be enough for such changes.
>> On 09.12.2020 18:58, Leonid Vasiliev wrote: And please remove the 
>> change in quotes for "tuple" in swap.test.py, it adds too many changes. 

reverted

--- a/test/replication-py/swap.test.py
+++ b/test/replication-py/swap.test.py
@@ -17,7 +17,7 @@ engines = ["memtx", "vinyl"]
  def insert_tuples(_server, begin, end, msg = "tuple"):
      for engine in engines:
          for i in range(begin, end):
-            print("box.space.{}:insert{{{}, '{} {}'}}".format(engine, 
i, msg, i))
+            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, 
i, msg, i))
              print("-")
              space = _server.iproto.py_con.space(engine)
              print(space.insert((i, "{} {}".format(msg, i))))

<snipped>



More information about the Tarantool-patches mailing list