[Tarantool-patches] [PATCH v1] Support to run tests with Python 3

Alexander Turenko alexander.turenko at tarantool.org
Tue Dec 8 21:04:26 MSK 2020


If you want my opinion, I think that the technical changes for support
Python 3 are enough. I don't mind style fixes, though.

> > > -        print len(tuple[0]) == size and 'ok' or 'fail',
> > > -        print
> > > -    print
> > > +        print(len(tuple[0]) == size and 'ok' or 'fail', end="")
> > > +        print()
> > > +    print()
> > 
> > 6) What for this `print()` needed? (and in the same changes below).
> 
> I don't know why you asked me because I'm not an author of these changes.
>
> But I'll try to answer. <...>

I see, you answered the question, but I would highlight this part of the
discussion.

When you touch some code, you becomes its owner. Any questions like 'how
it supposed to work / how it works' are applicable.

If a developer would legally respond 'it is not my deal' on questions
regarding changed code, we would accumulate tech debts even faster than
now.

Of course, there is a line, where it starts to contradict with a common
sense, but in general a knowledge about the changed code is required to
actually change it.

I find this approach nice. It pushes me to know more and be more
confident about my patches.


More information about the Tarantool-patches mailing list