[Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer

Cyrill Gorcunov gorcunov at gmail.com
Sat Dec 5 21:52:28 MSK 2020


On Sat, Dec 05, 2020 at 07:30:28PM +0100, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> >  char *
> > -backtrace(void)
> > +backtrace(char *start, char *end)
> 
> Why so strange choice of arguments? We almost always use char* + size_t,
> except for a few cases such as code working with tuples, where we 'save'
> time on not calculating 'end' in each next stack frame. Lets be consistent
> and use char* + size_t, not to raise unnecessary questions for such simple
> code.

Since start/end were calculated inside I juts moved them to arguments.
No problem, will use size instead.


More information about the Tarantool-patches mailing list