[Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access

Cyrill Gorcunov gorcunov at gmail.com
Wed Aug 19 23:49:27 MSK 2020


On Wed, Aug 19, 2020 at 10:37:30PM +0200, Vladislav Shpilevoy wrote:
> Hi! Today you said you did all the review fixes. I see that
> the branch didn't change, and this comment is still not
> addressed.
> >>
> >> The code is ugly as hell without it :/
> > 
> > There are many ugly things, but it does not mean we need to rush
> > changing them. It was discussed already many times. Please, drop
> > this commit. It is not necessary. It does not interfere with the
> > other patches in a single line.

Hmm, seems this your reply somehow drown in my inbox :( I'm pretty
damn sure that when we're changin the code we should improve it
if we can.

I'll update the branch and remove this commit.


More information about the Tarantool-patches mailing list